Thanks, Laurent Le 18 août 2017 7:29 PM, "Phil Race" <[email protected]> a écrit :
> CSR was approved and I have pushed the new API. > > -phil. > > On 08/17/2017 08:31 AM, Philip Race wrote: > > I have filed https://bugs.openjdk.java.net/browse/JDK-8186364 > and created and submitted the CSR for it : > https://bugs.openjdk.java.net/browse/JDK-8186365 > > -phil. > > On 8/17/17, 8:05 AM, Philip Race wrote: > > OK I'll handle the bureaucracy. > > -phil. > > On 8/17/17, 7:31 AM, Laurent Bourgès wrote: > > Phil, > Thanks for the explanations. > > I am not at home until next week so I would prefer if you can create the > new CSR and related bugs. > As I said, this patch was reviewed and I want it to be pushed in jdk10 > finally. > > PS: I worked again on Marlin to implement an efficient path clipper that > is working well and very promising performance. > > Cheers, > Laurent > > > Le 17 août 2017 00:33, "Phil Race" <[email protected]> a écrit : > >> It seems we are going to have to file a completely new bug for this. >> It is not just a case of your permissions. The migrated "CCC" can't be >> set to fix version 10. >> So Joe Darcy suggested creating a backport targeted to 10 and creating a >> CSR from that >> but it turns out backports can't have CSRs. Joe was a bit surprised by >> that. >> >> So >> 1) create a new bug which references and largely duplicates the original >> one >> 2) Create a CSR for JDK 10 for that. >> 3) Close the original bug as dup. of the new one. >> 4) Get CSR approval and push under the new bug id. >> We won't need to do a new code review. Just update the bugs with pointers >> to email threads explaining the relationship. >> >> If you want I can handle this hassle but if you want to do it you can too. >> >> >> -phil. >> >> On 08/11/2017 05:29 AM, Laurent Bourgès wrote: >> >> Ping ? >> In holidays ? >> >> Le 13 juil. 2017 9:36 AM, "Laurent Bourgès" <[email protected]> >> a écrit : >> >>> Jim or Phil, >>> Could you handle the CSR process on that patch and then push it in jdk10 >>> ? >>> >>> I consider that bug finished on my side. >>> >>> Laurent >>> >>> Le 8 juil. 2017 10:02, "Laurent Bourgès" <[email protected]> a >>> écrit : >>> >>>> Phil, >>>> >>>> Here are my comments on this CSR to be fixed in openjdk 10; I already >>>> submitted a patch and the review process happened in may. >>>> >>>> Le 3 juil. 2017 7:41 PM, "Phil Race" <[email protected]> a écrit : >>>> >>>> Laurent, >>>> >>>> Investigation has determined that since this was ported over in the >>>> "CCC migration project", >>>> due to the way that is set up it can't be assigned to non-Oracle >>>> employees. >>>> >>>> >>>> Ok, no problem. >>>> >>>> >>>> It won't affect any new CSRs that are created. >>>> >>>> Since the likelihood of any other similar case is extremely low, the >>>> simplest answer is >>>> that either Jim or myself will need to own and edit this one on your >>>> behalf. >>>> >>>> Send Jim or myself the changes you would like to make off-line and >>>> we'll take care of it. >>>> >>>> >>>> Just change the fix version to 10 and the @since javadoc tag as below: >>>> >>>> /** >>>> * Trims the capacity of this Path2D instance to its current >>>> * size. An application can use this operation to minimize the >>>> * storage of a path. >>>> * >>>> * @since 10 >>>> */ + public abstract void trimToSize(); >>>> >>>> It will match the proposed patch. >>>> >>>> Thanks, >>>> Laurent >>>> >>>> >>>> >>>>>>> 2017-04-20 23:04 GMT+02:00 Philip Race <[email protected]>: >>>>>>> >>>>>>>> You have a capital letter here and I think it must be lower case .. >>>>>>>> >>>>>>>> >>>>>>>> 2499 * @Since 10 >>>>>>>> >>>>>>>> -phil. >>>>>>>> >>>>>>>> >>>>>>>> On 4/20/17, 1:58 PM, Laurent Bourgès wrote: >>>>>>>> >>>>>>>> Hi Phil & Jim, >>>>>>>> >>>>>>>> Here is the updated webrev: >>>>>>>> http://cr.openjdk.java.net/~lbourges/path2D/Path2D-8078192.2/ >>>>>>>> >>>>>>>> Changes: >>>>>>>> - trimToSize() return void >>>>>>>> - fixed test + jtreg passed >>>>>>>> >>>>>>>> Bye, >>>>>>>> Laurent >>>>>>>> >>>>>>>> 2017-04-20 21:30 GMT+02:00 Jim Graham <[email protected]>: >>>>>>>> >>>>>>>>> Hi Laurent, >>>>>>>>> >>>>>>>>> The implementation looks good, except that the method >>>>>>>>> chaining-style return value seems out of place here. Similar >>>>>>>>> trimToSize() >>>>>>>>> methods in Collections return void and none of the other methods in >>>>>>>>> this >>>>>>>>> area use the method chaining paradigm. In the interest of >>>>>>>>> maintaining a >>>>>>>>> common design theme throughout 2D this method should just return void. >>>>>>>>> >>>>>>>>> ...jim >>>>>>>>> >>>>>>>>> >>>>>>>>> On 4/18/17 11:49 PM, Laurent Bourgès wrote: >>>>>>>>> >>>>>>>>>> Hi, >>>>>>>>>> >>>>>>>>>> Here is a first attempt to propose a Path2D patch (based on >>>>>>>>>> JDK10): >>>>>>>>>> http://cr.openjdk.java.net/~lbourges/path2D/Path2D-8078192.0/ >>>>>>>>>> >>>>>>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8078192 >>>>>>>>>> >>>>>>>>>> Please review the Path2D changes, notably the javadoc (english) >>>>>>>>>> and the modified Path2DCopyConstructor >>>>>>>>> >>>>>>>>> >> >
