Hi Sergey, Thanks for the comments. Here is updated version of the fix:
Webrev: http://cr.openjdk.java.net/~avu/JDK-8197499/webrev.02/ <http://cr.openjdk.java.net/~avu/JDK-8197499/webrev.02/> Best Regards, Alexey > On 12 Feb 2018, at 21:29, Sergey Bylokhov <sergey.bylok...@oracle.com> wrote: > > Hi, Alexey. > Two small comments: > - It looks like that after the fix we will reset the value to "null" even if > it was set by the user, for example the user may want to minimize the memory > footprint if he knows that application limite the size of the windows. > - setDoubleBufferMaximumSize includes clearImages() so it can be removed from > displayChanged(); > > On 12/02/2018 02:12, Alexey Ushakov wrote: >> Thanks, for the catch, Laurent! >> I forgot to remove my debug output that I used to detect the problem and >> verify the fix. It might be useful for reviewers though, so I left the >> original webrev as is and added the new one. >> Webrev: http://cr.openjdk.java.net/~avu/JDK-8197499/webrev.01/ >> Best Regards, >> Alexey >>> On 12 Feb 2018, at 12:14, Laurent Bourgès <bourges.laur...@gmail.com >>> <mailto:bourges.laur...@gmail.com>> wrote: >>> >>> Hi, >>> >>> I am not an official reviewer. >>> >>> I just noted you left a stdout statement that should be removed or >>> commented out (trace). >>> >>> You fix seems trivial >>> >>> Laurent >>> >>> Le 12 févr. 2018 09:14, "Alexey Ushakov" <alexey.usha...@jetbrains.com >>> <mailto:alexey.usha...@jetbrains.com>> a écrit : >>> >>> Hello, >>> >>> Here is the fix of the RepaintManager that adjust maximum double >>> buffer size after changes in the display environment. The fix is >>> targeted for openjdk10 but the problem exists in previous >>> releases. Please, have a look. >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8197499 >>> <https://bugs.openjdk.java.net/browse/JDK-8197499> >>> Webrev: http://cr.openjdk.java.net/~avu/JDK-8197499/webrev.00/ >>> <http://cr.openjdk.java.net/~avu/JDK-8197499/webrev.00/> >>> >>> Best Regards, >>> Alexey > > > -- > Best regards, Sergey.
