Hello Sergey
Thank you for your time in review & suggestions.
I understand both of your points-
. Need to examine cause of failure/ artifacts etc., and
. Suggestion to drop "-Dsun.java2d.opengl" from test cases.
The intent of this fix and many similar fixes to come is to stabilize our test
suite. So running OpenGL tests on un supported configurations can be avoided
for now. Post the stabilization, we can inspect OpenGL failures/ artifacts
where OpenGL isn't the default pipeline.
Hence, we not only need a provision to configure our automated build and test
systems to exclude OpenGL tests but also need a provision to execute tests
whenever required in future. The keywords approach helps to address both. Hence
this proposed fix.
Kindly let me know your views.
Thank you once again for your time
Have a good day
Prahalad N.
-----Original Message-----
From: Sergey Bylokhov
Sent: Wednesday, February 14, 2018 3:51 AM
To: Phil Race; Prahalad Kumar Narayanan; 2d-dev
Subject: Re: [OpenJDK 2D-Dev] [11] RFR: [JDK-8196451]
sun/java2d/OpenGL/DrawBufImgOp.java times out
On 13/02/2018 13:44, Phil Race wrote:
> In this case I can say that it was nothing to do with being slow .. it
> is a driver bug.
Even if behavior depends from the driver does not mean that it is a bug in
driver, we could do something wrong as well(since we have a bunch of artifacts
in opengl pipeline on windows/linux). But if we do not want to invest time to
investigate the reason of falure of this test on unsupported config(win+opengl)
then I assume the same decision will be done for other possible failures as
well.
I suggest to drop "-Dsun.java2d.opengl" option from our tests instead of
excluding the tests by keyword, so the tests will cover default system
pipeline(which is supported), and it will cover opengl on mac as well.
If it will be necessary to run the tests using some specific pipeline it will
be possible to pass a parameter to jtreg to run all the tests using one
pipeline.
>
> -phil
>
> On 02/13/2018 12:43 PM, Sergey Bylokhov wrote:
>> Hi, Prahalad, Phil.
>> Maybe it is possible to add a log from jtr file to the bug report,
>> usually it contains a stack trace on timeout. I am not sure that it
>> is a good idea to update any tests without reproducing it, when we
>> know that at least on one system it could be reproduced. The reasons
>> maybe a slow virtual system and we need to update a timeout.
>>
>>
>> On 13/02/2018 10:15, Prahalad Kumar Narayanan wrote:
>>> Hello Everyone
>>>
>>> Good day to you.
>>>
>>> Request your time in reviewing a minor change for a test bug
>>>
>>> [JDK-8196451] sun/java2d/OpenGL/DrawBufImgOp.java times out
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8196451
>>>
>>> Observation:
>>>
>>> . The bug reports a test case- DrawBufImgOp, failing with
>>> Timeout error on Win7 and OpenGL backend.
>>>
>>> . The issue wasn't reproducible despite multiple test runs on
>>> Win7 and Win10 machines.
>>>
>>> . Hence OpenGL driver issues on the host machine is suspected
>>> to have resulted in this Timeout.
>>>
>>> Code change:
>>>
>>> . The code changes add a new keyword- "opengl" to TEST.ROOT and
>>> the respective test case.
>>>
>>> . Since D3D is the preferred back-end on Windows, this keyword
>>> will be helpful to filter OpenGL tests from execution in future.
>>>
>>> . Note: There are many bugs that are similar to the current one.
>>> But it's hard to propose a common fix as some of the test cases
>>> execute with multiple @run tags (one for every back-end).
>>>
>>> Kindly review the change and suggest your views
>>>
>>> Link: http://cr.openjdk.java.net/~pnarayanan/8196451/webrev.00/
>>>
>>> Thank you for your time
>>>
>>> Have a good day
>>>
>>> Prahalad N.
>>>
>>
>>
>
--
Best regards, Sergey.
