> I thought this should be going through some JDK filtering already.
> It did in the old closed source case.

So in the old closed source case, we had our own little bit of code for filtering
the resultant bitmap. There's no code like that in freetypeScaler, and
code in ft_smooth_render_generic which applies the filter set by
FT_Library_SetLcdFilter does pretty much the same thing - it is applied
as a final step.

So I think it makes sense to call it here. If we can get a patch posted
I can review & test it.

-phil.

On 10/10/2018 11:36 AM, Philip Race wrote:
SFAIK OpenJDK still requires that fixes be posted on cr.openjdk.java.net
I don't think we are allowed to pull fixes from github, or to review changes there.
So an in-line patch would be better.
That will likely change with skara but not yet ..

Also reviews should start out with a thread with a bug ID.

I also need to look at how this patch applies (as in the sense if 'is applicable to') openjdk. I thought this should be going through some JDK filtering already.
It did in the old closed source case.

-phil.

On 10/10/18, 11:15 AM, Laurent Bourgès wrote:
Hi john,

It looks awesome & promising.

Phil, what do you think ?

PS: It is better to send plain text (long) email than sending external links (github).

Laurent

Le lun. 8 oct. 2018 à 22:24, John Neffenger <j...@status6.com <mailto:j...@status6.com>> a écrit :

    Now that we fixed a font problem in JavaFX [1], let's fix the same
    problem in Java. I would like your feedback on the Request for
    Enhancement described below:

    OpenJDK FreeType Font Fix
    https://github.com/jgneff/openjdk-freetype

    Thank you,
    John

    [1] https://github.com/javafxports/openjdk-jfx/issues/229


Reply via email to