Xavier Vilajosana writes: > we agreed on replacing the IEs description by several illustrative > examples. I worked a little bit on them and I would like to see what > is your opinion. As said they will be referred in the text and will > be placed at the end in an Examples section.
Good. > By now there are 3 examples and I need to work on one or two more security > related examples. > > Let's agree if this is a right format. (attached for reference and also at > bitbucket) Format looks right. One note you should make there is that all numbers are in LSB format. This includes length and element IDs, ASNs, join priorities etc. As in IETF we use network byte order, it might be better to explictly mention this, and also provide the final octet sequence for the frames. > https://bitbucket.org/6tisch/draft-ietf-6tisch-minimal/src/ > 88cd3c55a605ae194932bf0c7704570124732fd1/Example_1_EB_content.txt?at=master SubID name for "MLME-SubIE Timeslot" is missing "TSCH", i.e. the line: SubID = 0x1c (MLME-SubIE Timeslot) should be SubID = 0x1c (MLME-SubIE TSCH Timeslot) -- The format of Hopping timing IE (0x1d) is wrong. It is 5 octets, first 3 are the Present Hop Time Offset and last two are Hop Dwell Time. Also the name is wrong, i.e. the entry should be: #MLME-SubIE Hopping Timing Len5 = 5 Byte SubID = 0x1d (MLME-SubIE Hopping Timing) Type = Short (0) Present Hop Time Offset = 3 bytes Hop Dwell Time = 2 bytes -- The name of the TSCH Slotframe and link is wrong. I.e. change: #MLME-SubIE Frame and Link IE Len6 = 10Bytes SubID = 0x1b (MLME-SubIE Frame and Link) with #MLME-SubIE TSCH Slotframe and Link IE Len6 = 10Bytes SubID = 0x1b (MLME-SubIE TSCH Slotframe and Link) Also the field names do not match the 802.15.4, i.e. replace them with following: Number of slotframes = 0x01 SlotFrame Handle = 0x00 SlotFrame Size = 101 slots (0x65) Number of Links = 0x01 Timeslot = 0x0000 (2B) Channel Offset = 0x0000 (2B) Link Option = 0xE0 (tx,rx,shared) You also had Channel Offset and Timeslot in wrong order, Timeslot is first and Channel Offset is after that. Link options is the last one. Also I think your Link Option value is wrong as the bit 0 is the LSB of the first octet... -- Also the Payload IE Header Termination IE format is wrong. It should have 10 bit length field, and 4 bit GrpID value of 0xf with type of 1 (i.e. long). -- For the example 2 the correct name for of the IE is "Time Correction IE". -- Btw if you swap the order of TSCH Syncroniation IE and TSCH Timeslot IE then the fields in figure wrap better (i.e the 16-bit numbers do not warp from each line to next). -- [email protected] _______________________________________________ 6tisch mailing list [email protected] https://www.ietf.org/mailman/listinfo/6tisch
