On 12/11/25 17:09, Charles Forsyth wrote:
> - displacement = ((usize)buckets & 0b111111);
> + displacement = ((usize)buckets & (~(~0 << 6)) ); //0b111111 );
> 
> you could instead just use the 0x equivalent to the 0b. it's funny that i was 
> wondering about adding 0b but apparently 9front already has done.
> 
> 

I had added it when updating the power64 disassembler for POWER9. I didn't want 
to do the hex <-> binary conversions in my head while also dealing with
IBM's weird backwards notation.

If you're curious in it, I think the patch[0] should be mostly isolated. 
Although we did a slight refactor along with it.

[0] 
https://github.com/9front/9front/commit/3384b1e35a288f2e197d9ab75942cb5aa74fb5fc.diff

------------------------------------------
9fans: 9fans
Permalink: 
https://9fans.topicbox.com/groups/9fans/Te748e03814ed814b-M8a0c47c9821a2d81c0a5dfed
Delivery options: https://9fans.topicbox.com/groups/9fans/subscription

Reply via email to