Quoth [email protected]:
> Warnings
Yeah TBH a lot of those are just "I added something for debugging, it
worked with warnings, didn't bother fixing it, hadn't removed the
debug print yet".
> Patch...
- fprint(2, "entry found in bucket: arena %d, offset%d\n", aindex,
addr->offset);
+ fprint(2, "entry found in bucket: arena %lld, offset %lld\n", aindex,
addr->offset);
Almost definitely going to apply all of these, thanks.
- displacement = ((usize)buckets & 0b111111);
+ displacement = ((usize)buckets & (~(~0 << 6)) ); //0b111111 );
I'm... probably not going to merge patches that make the code more
obtuse in order to be compatible with the older compiler.
Actually, yes, I will - because neoventi is intended be merged into
9front as a replacement for venti outright Soon™, so I can use the
external repo as the more-compatible version?
+ return -1; /* shut up the compiler */
> 4th edition's cc doesn't allow functions without return at the end.
Nor does 9front's! If you remove the "abort()" call from the end of
that function, kencc would complain on 9front as well - but abort
cannot return, and is marked as such, so the compiler knows that there
is no unreachable end to the function ;)
I'll probably apply this fix to the non-9front version as well.
Current intention is to get neoventi good enough to replace venti as
the default implementation in 9front, then patch up the external repo
for non9front _afterwards_. I might just add a 4e branch to the repo
for now, and then make that the default later?
-char *configpath = "/dev/kaladin/arenas";
+char *configpath = "/dev/sdC1/arenas";
There's a `-c` option, as with venti/venti; I'll probably change the
default eventually, but not sure what to. Maybe just don't have one.
> procsetname > procsetname(2):
DESCRIPTION
Procsetname overrides the current process arguments by writ-
ing to its /proc/pid/args file. The process arguments are
informational only.
procsetname sets process info that can be viewed easily (looking at a
PID, which neoventi proc is it?); threadsetname is internal to
libthread and AFAIK cannot be accessed from the outside. I don't see
much point in keeping it at that point.
> archWalk: ... unimplemented
Interesting, there's likely a few places where I'm hanging up the
connection on error / unknown op where I could be warning and moving
on since I hadn't tested with a continuous write-mode connection, only
vacfs. Thanks, will look more :)
> Perhaps make neoventi fork to background when it is ready to use
with fossil?
Probably! Haven't gotten there yet.
Thanks for taking a look, I'll apply the fixes soon :)
------------------------------------------
9fans: 9fans
Permalink:
https://9fans.topicbox.com/groups/9fans/Te748e03814ed814b-M3891ced3b60cd010d1731427
Delivery options: https://9fans.topicbox.com/groups/9fans/subscription
