Re: iconv vs. libiconv, was Re: Patch: Fix for Bug 1164, 2nd try

[ha shao]

On Wed, May 23, 2001 at 03:51:42PM +1000, [EMAIL PROTECTED] wrote:
> This seems related.  I've noticed in xap_EncodingManager.cpp the
> function charsetFromCodepage returns "GB2312", "BIG5", etc instead
> 
> of "CP936", "CP950", etc even when the iconv supports
>  the "CPxxx"
> form and the encodings differ.
> 
> 
> I've looked at where this function is called and it seems to me this
> opens the door to lossy conversions.  Should this function also use
> some form of fallback so that "BIG5" is only returned when iconv
> doesn't support "CP950"?  Or maybe this function is ambiguous and
> really should be two separate functions?

This is what I've suggested in another mail. Yes, please replace
the mapping to a fallback call/macros.

-- 
Best regard
hashao