Hi Mark

I'd prefer an exact match, but given the containers don't provide a
HttpServletRequest getter which consistently can be used for an exact
comparison, we'll have to do some String VooDoo.

A slightly more restrictive alternative (in that it would fire incorrectly
less often) would be:

httpRequest.getRequestURL().endsWith(httpRequest.getContextPath() +
filterProcessesUrl); 

Colin, do you think this would create any additional issues?

Mark, I don't mind making the change, but I'm just stepping cautiously as it
is obviously a shade of grey between various containers. Would you mind
trying the above code and letting me know if it works? If it does, and I
make it on my development build and if it still passes the four container
integration tests, we'll commit it to CVS.

Best regards
Ben

________________________________

        From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of
Mark St Godard
        Sent: Thursday, 10 June 2004 12:22 AM
        To: [EMAIL PROTECTED]
        Subject: Re: [Acegisecurity-developer] HttpServletRequest getters
        
        

        Thanks for the info, Colin. 
        
        Ben, should we then be using the Request URL... 
        and doing some String VooDoo ala 
        
           httpRequest.getRequestURL().endsWith(filterProcessesUrl) 
        
        or pick off the last token and compare.. whatever 
        
        Regardless, let me know how and when you are going to fix this.. OR 
        
        Let me know if you wanted me to submit a bug report and patch 
        
        



-------------------------------------------------------
This SF.Net email is sponsored by: GNOME Foundation
Hackers Unite!  GUADEC: The world's #1 Open Source Desktop Event.
GNOME Users and Developers European Conference, 28-30th June in Norway
http://2004/guadec.org
_______________________________________________
Acegisecurity-developer mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/acegisecurity-developer

Reply via email to