Hi Ben,
I have tried a modified version of your original code snippet:
httpRequest.getRequestURL().toString().endsWith(
httpRequest.getContextPath() + filterProcessesUrl);
Note: getRequestURL returns a java.lang.StringBuffer (odd, anyway thats
something new I learned today :)
or also could be reworked to:
String requestUrl = httpRequest.getRequestURL().toString();
requestUrl.endsWith(httpRequest.getContextPath() + filterProcessesUrl);
So other than checks for null, etc... it works fine on both of the servlet
/ app servers that I use:
WebSphere Platform 5.1 [BASE 5.1.0 b0344.02]
Host Operating System is Linux, version 2.4.21-9.0.1.EL
Java version = J2RE 1.4.1 IBM J9 build 20030915 (JIT enabled)
Tomcat 4.1.30
Using CATALINA_BASE: /usr/local/jakarta-tomcat-4.1.30
Using CATALINA_HOME: /usr/local/jakarta-tomcat-4.1.30
Using JAVA_HOME: /opt/j2sdk1.4.2_04
Thanks and let me know if you need anything
Mark
|---------+--------------------------------------------------->
| | "Ben Alex" <[EMAIL PROTECTED]> |
| | Sent by: |
| | [EMAIL PROTECTED]|
| | ceforge.net |
| | |
| | |
| | 06/09/2004 04:57 PM |
| | Please respond to |
| | acegisecurity-developer |
|---------+--------------------------------------------------->
>----------------------------------------------------------------------------------------------|
|
|
| To: <[EMAIL PROTECTED]> |
| cc:
|
| Subject: RE: [Acegisecurity-developer] HttpServletRequest getters
|
|
|
|
|
>----------------------------------------------------------------------------------------------|
Hi Mark
I'd prefer an exact match, but given the containers don't provide a
HttpServletRequest getter which consistently can be used for an exact
comparison, we'll have to do some String VooDoo.
A slightly more restrictive alternative (in that it would fire incorrectly
less often) would be:
httpRequest.getRequestURL().endsWith(httpRequest.getContextPath() +
filterProcessesUrl);
Colin, do you think this would create any additional issues?
Mark, I don't mind making the change, but I'm just stepping cautiously as
it
is obviously a shade of grey between various containers. Would you mind
trying the above code and letting me know if it works? If it does, and I
make it on my development build and if it still passes the four container
integration tests, we'll commit it to CVS.
Best regards
Ben
________________________________
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of
Mark St Godard
Sent: Thursday, 10 June 2004 12:22 AM
To: [EMAIL PROTECTED]
Subject: Re: [Acegisecurity-developer] HttpServletRequest
getters
Thanks for the info, Colin.
Ben, should we then be using the Request URL...
and doing some String VooDoo ala
httpRequest.getRequestURL().endsWith(filterProcessesUrl)
or pick off the last token and compare.. whatever
Regardless, let me know how and when you are going to fix
this.. OR
Let me know if you wanted me to submit a bug report and patch
-------------------------------------------------------
This SF.Net email is sponsored by: GNOME Foundation
Hackers Unite! GUADEC: The world's #1 Open Source Desktop Event.
GNOME Users and Developers European Conference, 28-30th June in Norway
http://2004/guadec.org
_______________________________________________
Acegisecurity-developer mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/acegisecurity-developer
-------------------------------------------------------
This SF.Net email is sponsored by: GNOME Foundation
Hackers Unite! GUADEC: The world's #1 Open Source Desktop Event.
GNOME Users and Developers European Conference, 28-30th June in Norway
http://2004/guadec.org
_______________________________________________
Acegisecurity-developer mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/acegisecurity-developer
