Yeah, I totally agree. Applying Jalopy on the new code works well because it adds all the file header stuff. After that though, checkstyle is much more effective. Unfortunately we haven't been adhering to the Checkstyle requirements from the start. That will take some effort to bring the errors down as you've said.
We use findbugs pretty extensively where I work. Combine the two and now you've got some serious automated nagging going on :) On 4/20/07, Luke Taylor <[EMAIL PROTECTED]> wrote: > Hi Ray, > > I'm against using Jalopy - it's messed up far too much stuff in the past > and really chews up comments and makes it hard to follow the commit log > properly. I think we should use something like checkstyle to monitor the > adherence to code standards and just change stuff that doesn't fit manually. > > Checkstyle can also be integrated quite easily with IntelliJ and seems > to work pretty well. It's very configurable. I put a file into the > project a while back, so we just need to make sure it contains the right > constraints (which I'm a bit hazy on :) ). > > The maven report also flags stuff up that doesn't match > > http://monkeymachine.co.uk/acegisecurity/acegi-security/checkstyle.html > > It's a gentler approach than Jalopy. If there's concern that nobody will > bother then (once we get the list of errors down to zero) I can get the > build to mail out a warning when someone commits code that breaks the > standards. > > cheers, > > Luke. > > Ray Krueger wrote: > > I'm putting the finishing touches on Robin's OpenID contribution. I've > > run Jalopy of the code using some busted old IntelliJ plugin a few > > times. It complains about all sorts of stuff at this point, and I was > > wondering... > > > > Is Jalopy dead? It sure looks like it at: http://jalopy.sourceforge.net > > > > Are there other options out there? > > > > > > -- > Luke Taylor. Monkey Machine Ltd. > PGP Key ID: 0x57E9523C http://www.monkeymachine.ltd.uk > > > ------------------------------------------------------------------------- > This SF.net email is sponsored by DB2 Express > Download DB2 Express C - the FREE version of DB2 express and take > control of your XML. No limits. Just data. Click to get it now. > http://sourceforge.net/powerbar/db2/ > _______________________________________________ > Home: http://acegisecurity.org > Acegisecurity-developer mailing list > Acegisecurity-developer@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/acegisecurity-developer > ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ Home: http://acegisecurity.org Acegisecurity-developer mailing list Acegisecurity-developer@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acegisecurity-developer
