https://bugzilla.kernel.org/show_bug.cgi?id=15100





--- Comment #69 from Bjorn Helgaas <bjorn.helg...@hp.com>  2011-01-10 18:01:36 
---
I'm not sure I understand the rationale for the patch in comment 65.  It looks
like we're just exchanging the cached "pnp_dev->data->handle" for "lookup
DEVICE_ACPI_HANDLE(pnp_dev->dev) and handle failure gracefully."  It sounds
like it fixes this problem, but it feels like a pnp_dev lifetime issue that
could bite us again somewhere else.

Is this the scenario:

  - boot docked (dock contains a UART)
  - make a PNP serial device
  - suspend to RAM
  - undock
  - resume (now the UART is gone)
  - resume the PNP serial device
  - dock.c notices UART removal
  - remove the PNP serial device

It seems sort of backwards to resume all the devices, then check to see whether
any of them were removed.

I know we would need a lot of ACPI rework to deal with the Bus Check
notification before resuming devices, but I wonder if that's the cleaner
long-term approach.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

------------------------------------------------------------------------------
Gaining the trust of online customers is vital for the success of any company
that requires sensitive data to be transmitted over the Web.   Learn how to 
best implement a security strategy that keeps consumers' information secure 
and instills the confidence they need to proceed with transactions.
http://p.sf.net/sfu/oracle-sfdevnl 
_______________________________________________
acpi-bugzilla mailing list
acpi-bugzilla@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla

Reply via email to