To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=79368
------- Additional comments from [EMAIL PROTECTED] Tue Jul 24 16:16:29 +0000 2007 ------- The logic of patch is okay, but I do not feel very comfortable with the many String objects that are created. Would it be possible to create less? One may for instance keep only char* and string lengths in the array aTmp, and may create the Strings in the loop. In particular, I feel not comfortable with the comparison aTmp[k].equals(OUString()). Checking the length of aTmp[k] should be sufficient. I'm further wondering whether the XML_IMAGE case and service map entry is required. Images are a different type of documents than graphics, and are not supported by OOo. Beside that, I have no objections if you create a CWS to integrate the patch. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
