To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=89440
------- Additional comments from [EMAIL PROTECTED] Mon Jun 9 09:50:04 +0000 2008 ------- TL: "yes, all code for getting and setting SID_LANGUAGE_STATUS is duplicated around three time, now even once more in annotsh.cxx as well" >_< Please see if you can avoid code duplication by extracting common functionality in a new function and by providing additional parameters. Many weeks ago I spend some days to do the same. It would be sad if the code now needs to be duplicated again. ^^° You are likely to need at least two different versions though. One for the Writer document and one to be used with drawing objects. It will also be Ok if you submit an issue to me to try to do this. You just need to tell me all the new locations along with the old ones and I will try to remove code duplication if it can be done with reasonable effort. For the time being it will be nice though if you could add comments to the original and the duplicated code (referencing each other) in order to not forget to have a look at the other code parts if something needs to be changed later on. Thanks! :-) --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
