Tim Goetze wrote:
> 
> >here's a better version (i think):
> >
> >* You should pass this function the offset value that
> >* snd_pcm_mmap_begin returned. The frames parameter should hold the
> >* number of frames you have written or read to/from the audio
> >* buffer. Each call to snd_pcm_mmap_begin() may be followed by a
> >* series of zero or more calls to snd_pcm_mmap_commit(). If
> >* snd_pcm_mmap_begin() returned N frames, the sum of all frames
> >* recorded as written or read by that corresponding series of calls to
> >* snd_pcm_mmap_commit() may not exceed N.
> 
> much better. very dense, and very enlightening. i have turned this
> into a patch, too.

I can confirm the correctness of the comment, although the comment does
not state well that offset has to be rerequested (then I'd exclude the
possibility to have multiple mmap_commit for one mmap_begin).

I know that this is harmless on most types of PCM but it might not be
true for all PCMs.

Also I don't see the benefits to split the commits.

-- 
Abramo Bagnara                       mailto:[EMAIL PROTECTED]

Opera Unica                          Phone: +39.546.656023
Via Emilia Interna, 140
48014 Castel Bolognese (RA) - Italy

ALSA project               http://www.alsa-project.org
It sounds good!

_______________________________________________
Alsa-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/alsa-devel

Reply via email to