Jaroslav Kysela wrote:
> 
> On Thu, 1 Nov 2001, Abramo Bagnara wrote:
> 
> >
> > I have to partially disagree, nothing inhibits to do:
> >
> > frames = buffer_size;
> > snd_pcm_mmap_begin(pcm, areas, &offset, &frames);
> >
> > and then reduce the number of frames to call snd_pcm_mmap_commit with.
> >
> > Perhaps it's useless, but this is how I designed this API.
> 
> Yes, while we have the mmap_begin function limiting the transfer count and
> application knows how many samples should be filled, the reducing the
> counf of channel is really not necessary. I think that it would be better
> to avoid to do this by programmers, because we can use the mmap_commit
> size count for some internal purposes (a temporary buffer for frames
> freeing etc..) in future. It's not really any pain from the developer
> view, but if you don't agree with my, I'm ready to change your (or
> me?) comment for the mmap_commit function.

I agree with you.

My proposal is to leave your comment unless someone is capable to show
us a valid reason to need to further reduce number of frames commited.

-- 
Abramo Bagnara                       mailto:[EMAIL PROTECTED]

Opera Unica                          Phone: +39.546.656023
Via Emilia Interna, 140
48014 Castel Bolognese (RA) - Italy

ALSA project               http://www.alsa-project.org
It sounds good!

_______________________________________________
Alsa-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/alsa-devel

Reply via email to