----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107796/#review23664 -----------------------------------------------------------
Hi, thanks for the patch! Please have a look at smaller issues bellow, and it would be nice if you could attach a screenshot before/after. src/playlist/view/listview/PrettyItemDelegate.cpp <http://git.reviewboard.kde.org/r/107796/#comment18111> Please don't introduce leading whitespace, the line should be empty. src/playlist/view/listview/PrettyItemDelegate.cpp <http://git.reviewboard.kde.org/r/107796/#comment18113> So perhaps the svg file queue_maker (.svg?) can be removed now? If so, please remove it in the patch, use `git rm`. src/playlist/view/listview/PrettyItemDelegate.cpp <http://git.reviewboard.kde.org/r/107796/#comment18112> You are just computing floor of the 10-base logarithm of queuePosition here, don't do it manually. src/playlist/view/listview/PrettyItemDelegate.cpp <http://git.reviewboard.kde.org/r/107796/#comment18114> Unfortunately, we cannot hard-code colours in code (and if queue_marker used hard-coded colours, it was an error). We have to use KColorScheme( QPalette::Active ) so use user's current color scheme so that enough contrast is quaranteed. Please choose a background colour from KColorScheme that goes with the current playlist window background. Perhaps PositiveBackground. - Matěj Laitl On Dec. 18, 2012, 10:47 a.m., Riccardo Ferrazzo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107796/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2012, 10:47 a.m.) > > > Review request for Amarok. > > > Description > ------- > > I've replaced the svg queue icon with a painted green rounded rectangle that > scale based on the digits to display > > > This addresses bug 253802. > https://bugs.kde.org/show_bug.cgi?id=253802 > > > Diffs > ----- > > src/playlist/view/listview/PrettyItemDelegate.cpp c13542b > > Diff: http://git.reviewboard.kde.org/r/107796/diff/ > > > Testing > ------- > > > Thanks, > > Riccardo Ferrazzo > >
_______________________________________________ Amarok-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/amarok-devel
