----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107796/#review24897 -----------------------------------------------------------
Sorry to be so nitpicking, but could we have at least the same color for the new icon? The color of the old icon fits in the current icon scheme, so this should be respected. - Myriam Schweingruber On Jan. 7, 2013, 10:37 a.m., Riccardo Ferrazzo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107796/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2013, 10:37 a.m.) > > > Review request for Amarok. > > > Description > ------- > > I've replaced the svg queue icon with a painted green rounded rectangle that > scale based on the digits to display > > > This addresses bug 253802. > https://bugs.kde.org/show_bug.cgi?id=253802 > > > Diffs > ----- > > src/images/default-theme-clean.svg 6bad334 > src/images/default-theme.svg dbd3c90 > src/playlist/view/listview/PrettyItemDelegate.cpp c13542b > > Diff: http://git.reviewboard.kde.org/r/107796/diff/ > > > Testing > ------- > > > Screenshots > ----------- > > before > http://git.reviewboard.kde.org/r/107796/s/918/ > after > http://git.reviewboard.kde.org/r/107796/s/919/ > > > Thanks, > > Riccardo Ferrazzo > >
_______________________________________________ Amarok-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/amarok-devel
