-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107796/#review24949
-----------------------------------------------------------
Nice work Riccardo, especially finding the right objects to delete in SVG
files. However, the patch no longer applies to current git, please
1. (unless you have solved merge conflicts in git before) make backup: git
branch master-backup master
2. git pull --rebase
3. solve trivial merge conflict (include got moved), solve my last nitpick
(sorry about it, I wouldn't normally care that much, but since you're already
updating..) and upload
Thanks!
src/playlist/view/listview/PrettyItemDelegate.cpp
<http://git.reviewboard.kde.org/r/107796/#comment19127>
Extreme nitpick:
we prefer constructor style casts int( float value ) for primitive types to
C-style casts per
http://qt-project.org/wiki/Coding-Conventions#32c00b11a9d4fa4bf1186733a599fc97
-> Casting
- Matěj Laitl
On Jan. 7, 2013, 10:37 a.m., Riccardo Ferrazzo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107796/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2013, 10:37 a.m.)
>
>
> Review request for Amarok.
>
>
> Description
> -------
>
> I've replaced the svg queue icon with a painted green rounded rectangle that
> scale based on the digits to display
>
>
> This addresses bug 253802.
> https://bugs.kde.org/show_bug.cgi?id=253802
>
>
> Diffs
> -----
>
> src/images/default-theme-clean.svg 6bad334
> src/images/default-theme.svg dbd3c90
> src/playlist/view/listview/PrettyItemDelegate.cpp c13542b
>
> Diff: http://git.reviewboard.kde.org/r/107796/diff/
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
> before
> http://git.reviewboard.kde.org/r/107796/s/918/
> after
> http://git.reviewboard.kde.org/r/107796/s/919/
>
>
> Thanks,
>
> Riccardo Ferrazzo
>
>
_______________________________________________
Amarok-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/amarok-devel
