> On Dec. 18, 2012, 6:42 p.m., Edward Hades Toroshchin wrote: > > src/playlist/view/listview/PrettyItemDelegate.cpp, line 48 > > <http://git.reviewboard.kde.org/r/107796/diff/3/?file=100236#file100236line48> > > > > Could you please reorder the headers according to > > HACKING/intro_and_style.txt: > > > > Header includes should be listed in the following order: > > - Own Header > > - Amarok includes > > - KDE includes > > - Qt includes > >
Excuse me, now it's fixed! - Riccardo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107796/#review23700 ----------------------------------------------------------- On Dec. 18, 2012, 7 p.m., Riccardo Ferrazzo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107796/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2012, 7 p.m.) > > > Review request for Amarok. > > > Description > ------- > > I've replaced the svg queue icon with a painted green rounded rectangle that > scale based on the digits to display > > > This addresses bug 253802. > https://bugs.kde.org/show_bug.cgi?id=253802 > > > Diffs > ----- > > src/images/default-theme-clean.svg 6bad334 > src/images/default-theme.svg dbd3c90 > src/playlist/view/listview/PrettyItemDelegate.cpp c13542b > > Diff: http://git.reviewboard.kde.org/r/107796/diff/ > > > Testing > ------- > > > Screenshots > ----------- > > before > http://git.reviewboard.kde.org/r/107796/s/918/ > after > http://git.reviewboard.kde.org/r/107796/s/919/ > > > Thanks, > > Riccardo Ferrazzo > >
_______________________________________________ Amarok-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/amarok-devel
