From: Alex Hung <[email protected]> [WHAT] Document the amdgpu_dm struct members and function parameters reported by kernel-doc. Convert non-kernel-doc prose comments to regular comments and clarify the HDMI FRL polling fields.
Reported-by: kernel test robot <[email protected]> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/ Assisted-by: Copilot:GPT-5.6-Luna Reviewed-by: Jerry Zuo <[email protected]> Signed-off-by: Alex Hung <[email protected]> Signed-off-by: George Zhang <[email protected]> --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 7 ++++++- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.h | 9 +++++++++ .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.h | 2 +- 3 files changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h index a02e906178b1..2ead9bc8e439 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h @@ -593,6 +593,11 @@ struct amdgpu_display_manager { struct amdgpu_dm_backlight_caps backlight_caps[AMDGPU_DM_MAX_NUM_EDP]; struct mod_freesync *freesync_module; + /** + * @power_module: + * + * Power management module. + */ struct mod_power *power_module; struct hdcp_workqueue *hdcp_workqueue; @@ -734,7 +739,7 @@ struct amdgpu_display_manager { /** * @hdmi_frl_status_polling_wq: * - * workqueue for 200ms frl status polling + * Workqueue for HDMI FRL status polling. */ struct workqueue_struct *hdmi_frl_status_polling_wq; /** diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.h b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.h index bc16ecc67329..6ba567df5f0a 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.h +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.h @@ -44,6 +44,8 @@ enum dmub_notification_type; * * This function should be called exactly once - during DM initialization. * + * @adev: AMDGPU device. + * * Returns: * 0 - success * non-zero - error @@ -55,6 +57,8 @@ int amdgpu_dm_irq_init(struct amdgpu_device *adev); * * This function should be called exactly once - during DM destruction. * + * @adev: AMDGPU device. + * */ void amdgpu_dm_irq_fini(struct amdgpu_device *adev); @@ -82,6 +86,7 @@ void *amdgpu_dm_irq_register_interrupt(struct amdgpu_device *adev, * by amdgpu_dm_irq_register_interrupt(). * * @adev: AMD DRM device. + * @irq_source: IRQ source to unregister. * @ih_index: irq handler index which was returned by * amdgpu_dm_irq_register_interrupt */ @@ -126,6 +131,8 @@ void amdgpu_dm_hpd_fini(struct amdgpu_device *adev); /** * amdgpu_dm_irq_suspend - disable ASIC interrupt during suspend. * + * @adev: AMDGPU device. + * */ void amdgpu_dm_irq_suspend(struct amdgpu_device *adev); @@ -133,6 +140,8 @@ void amdgpu_dm_irq_suspend(struct amdgpu_device *adev); * amdgpu_dm_irq_resume_early - enable HPDRX ASIC interrupts during resume. * amdgpu_dm_irq_resume - enable ASIC interrupt during resume. * + * @adev: AMDGPU device. + * */ void amdgpu_dm_irq_resume_early(struct amdgpu_device *adev); void amdgpu_dm_irq_resume_late(struct amdgpu_device *adev); diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.h b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.h index 4436d256a2ae..21fedc5f21bd 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.h +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.h @@ -37,7 +37,7 @@ #define DP_BRANCH_VENDOR_SPECIFIC_START 0x50C -/** +/* * Panamera MST Hub detection * Offset DPCD 050Eh == 0x5A indicates cascaded MST hub case * Check from beginning of branch device vendor specific field (050Ch) -- 2.55.0
