Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] docs: ioctl-number: duplicate bnep.h entry and missing conflict
  marker
--

commit acf95c4d46bf87ab8fab382911993f6e83864afc
Author: Randy Dunlap <[email protected]>

docs: ioctl-number: update networking entries

This commit updates the networking ioctl file paths and function number
ranges in Documentation/userspace-api/ioctl/ioctl-number.rst.

> diff --git a/Documentation/userspace-api/ioctl/ioctl-number.rst 
> b/Documentation/userspace-api/ioctl/ioctl-number.rst
> index 2b2d3fd317158..cd4f0bf6db66a 100644
> --- a/Documentation/userspace-api/ioctl/ioctl-number.rst
> +++ b/Documentation/userspace-api/ioctl/ioctl-number.rst
> @@ -132,6 +132,7 @@ Code  Seq#    Include File                                
>              Comments
>  'B'   00-0F  include/linux/pmu.h                                       
> conflict!
>  'B'   C0-FF  advanced bbus                                             
> <mailto:[email protected]>
>  'B'   00-0F  xen/xenbus_dev.h                                          
> conflict!
> +'B'   C8-D4  net/bluetooth/bnep/bnep.h                                 
> <mailto:[email protected]>
>  'C'   all    linux/soundcard.h                                         
> conflict!
>  'C'   00-68  sound/compress_offload.h                                  
> conflict!
>  'C'   01-2F  linux/capi.h                                              
> conflict!
> @@ -173,7 +174,7 @@ Code  Seq#    Include File                                
>              Comments
>  'H'   FC     sound/pci/asihpi/hpios.h                                  
> conflict!
>  'H'   00-0F  uapi/misc/habanalabs.h                                    
> conflict!
>  'H'   A0     uapi/linux/usb/cdc-wdm.h
> -'H'   C0-F0  net/bluetooth/hci.h                                       
> conflict!
> +'H'   C0-F0  net/bluetooth/hci_sock.h                                  
> conflict!
>  'H'   C0-DF  net/bluetooth/hidp/hidp.h                                 
> conflict!
>  'H'   C0-DF  net/bluetooth/cmtp/cmtp.h                                 
> conflict!
>  'H'   C0-DF  net/bluetooth/bnep/bnep.h                                 
> conflict!

[Severity: Low]
Should the 'H' C0-DF entry for net/bluetooth/bnep/bnep.h be removed now
that 'B' C8-D4 is added, and should the 'B' C0-FF and 'B' C8-D4 entries
be marked with conflict!?

net/bluetooth/bnep/bnep.h only defines 'B' ioctls (BNEPCONNADD through
BNEPGETSUPPFEAT, 200-212) and none with code 'H', while 'B' C8-D4
overlaps with the 'B' C0-FF range for advanced bbus.

-- 
Sashiko AI review ยท 
https://sashiko.dev/#/patchset/[email protected]?part=4

Reply via email to