Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] docs: ioctl-number: ext4 00-2F ioctl range points to fs/ext4/ext4.h instead of uapi/linux/ext4.h --
commit 9072a8199d2be085dc5ab2567392180faf810c6d Author: Randy Dunlap <[email protected]> docs: ioctl-number: update FS entries This commit updates the header file paths and sequence number ranges for filesystem ioctls in Documentation/userspace-api/ioctl/ioctl-number.rst. > diff --git a/Documentation/userspace-api/ioctl/ioctl-number.rst > b/Documentation/userspace-api/ioctl/ioctl-number.rst > index 87e547be9e2ac..abc89b6288ba3 100644 > --- a/Documentation/userspace-api/ioctl/ioctl-number.rst > +++ b/Documentation/userspace-api/ioctl/ioctl-number.rst [ ... ] > @@ -275,7 +276,7 @@ Code Seq# Include File > Comments > 'f' 00-1F linux/ext2_fs.h > conflict! > 'f' 00-1F linux/ext3_fs.h > conflict! > 'f' 00-0F fs/jfs/jfs_dinode.h > conflict! > -'f' 00-0F fs/ext4/ext4.h > conflict! > +'f' 00-2F fs/ext4/ext4.h > conflict! [Severity: Low] Should this entry point to uapi/linux/ext4.h (or both headers) instead of only fs/ext4/ext4.h? Commit 519fe1bae7e2 ("ext4: Add a uapi header for ext4 userspace APIs") moved the EXT4_IOC_* definitions spanning 0x03 through 0x2E into include/uapi/linux/ext4.h, leaving only the compat EXT4_IOC32_* definitions (0x03 through 0x08) in fs/ext4/ext4.h. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=10
