Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] docs: ioctl-number: missing update of 'O' range for
  mtd/ubi-user.h to 00-08
--

commit ccf1b77b46484d55fbc7ee02d93a71ebab16f010
Author: Randy Dunlap <[email protected]>

docs: ioctl-number: update MTD entries

This commit updates the sequence number ranges and file entries for MTD
and UBI ioctls in Documentation/userspace-api/ioctl/ioctl-number.rst.

> diff --git a/Documentation/userspace-api/ioctl/ioctl-number.rst 
> b/Documentation/userspace-api/ioctl/ioctl-number.rst
> index d47f817335666..1ff4fd4bf9b5c 100644
> --- a/Documentation/userspace-api/ioctl/ioctl-number.rst
> +++ b/Documentation/userspace-api/ioctl/ioctl-number.rst

[ ... ]

> @@ -306,7 +306,7 @@ Code  Seq#    Include File                                
>              Comments
>  'n'   E0-FF  linux/matroxfb.h                                          
> matroxfb
>  'n'   F8-FA  video/sisfb.h                                             sisfb
>  'o'   00-1F  fs/ocfs2/ocfs2_fs.h                                       OCFS2
> -'o'   00-03  mtd/ubi-user.h                                            
> conflict! (OCFS2 and UBI overlaps)
> +'o'   00-06  mtd/ubi-user.h                                            
> conflict! (OCFS2 and UBI overlap)

[Severity: Low]
Should the 'O' entry for mtd/ubi-user.h also be updated from 00-06 to
00-08?  include/uapi/mtd/ubi-user.h defines UBI_VOL_IOC_MAGIC ('O')
ioctls up to 8 (UBI_IOCVOLCRBLK at 7 and UBI_IOCVOLRMBLK at 8).

-- 
Sashiko AI review ยท 
https://sashiko.dev/#/patchset/[email protected]?part=7

Reply via email to