Hi Sake, Like vivia said, the best way to send a patch is to save your work, do a 'svn update', then 'svn diff', and send us the diff result... Now, I'm sorry but I don't understand what you did... with this fix... it has nothing to do with what was asked... Maybe you forgot to send the diff for the chatwindow.tcl file or something.. or maybe you misunderstood.. humm.. ok, I just reread the forum thread and you're right, I'm the one who misunderstood.. I was actually refering to the line in the post that says : "The menu view->text size, isn't user friendly" referring to the menu of the chatwindow, wich is why I told you to look at the CreateTextSizeMenu in chatwindow.tcl... Now I understand your diff a bit better.. but I' masking myself, why the -nosizes 1 was put there in the first place ? that's what you should ask yourself.. see who added it and when and for what reason, maybe the sizes column caused a bug or something.. I'll try to find that answer for you, in the meantime, you could try changing the chat window's menus so it could be more user friendly (now it's +1, +2, etc.. maybe font sizes would be better).. maybe the whole 'text size' menu could be removed and just add a single menu entry to change the font of how you see user's text, so they get it all in one window (the same button is in the prefs window)
KaKaRoTo On Tue, Mar 20, 2007 at 02:20:32AM -0400, Sake Sashimi wrote: > Hi Kakaroto, > > I manage to finish the first TODO (better usable menu options for changing > text size) > > http://www.amsn-project.net/forums/viewtopic.php?t=2827 - better usable menu > options for the change text size... > > Basically, I modified gui.tcl file within choose_font and change_font > procs. Right now, if user click the 'change font' button in the chat > window, and also the two 'change buttons' in Preference->Appearance, a > change font window with additional font size list column will appear. User > can change text size by selecting the size number on the list. The change > will be persistent. > > I have tested it thoroughly, and it works consistently. The only thing is > that, if you ever notice, some fonts have a range sizes in which if you > change the size within that range, the size of the font does not change (for > example: for font 'times', size between 19 to 22 does not actually change > the size of the font, ie: size 19 to 22 is the same size for font 'times'). > I am sure this is not amsn issue. it probably tcl issue. > > I am not too familiar about the process of submitting the code. I attached > the file that I modified in this email. I hope my change is acceptable :) > Please let me know if there is a specific way to send fixes. > > Thank you, > sakesashimi > ------------------------------------------------------------------------- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys-and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > _______________________________________________ > Amsn-devel mailing list > Amsn-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/amsn-devel ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Amsn-devel mailing list Amsn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/amsn-devel
