Hi Kakaroto and everyone,
I went ahead and change the way user will choose font size from menu->text
size as you have suggested. So, instead of +8 +4 ... etc, user will now be
able to choose font size, ie: 4,5,6,7,8,9,10...24. I tested the change and
it works properly.
I attached the diff file (font_diff.txt) as the email attachment. Sorry, it
is because gmail does not allow me to copy paste (really weird indeed) :(
In font_diff.txt, the first diff on chatwindow.tcl is the new implementation
on menu->text size that you suggested me to do.
The second diff on gui.tcl is the previous implementation I did on adding
size column. They are separate.
Thanks a lot. I look forward to hearing your feedback :)
Regards,
Sakesashimi
On 3/20/07, Sake Sashimi <[EMAIL PROTECTED]> wrote:
Hi Kakaroto,
Thanks for your reply. I was previously thinking that the size column was
not there because amsn already has the menu entry to increase or decrease
the text size. Therefore, with this in mind, the person who
implemented the Change Font window purposedly left out the size column
From what I understood from the forum thread, the one requesting the
feature was asking if amsn could have a window with all three options (to
change font name, size and style) similar to the window on
Preference->Appearance->Change Font on the chat window and on
Preference->Personal->Change Fonts buttons. Right now, if user click the
'A' button on chat windows, a new windows showing what was requested appears
and user will be able to change all three parameters from that one window.
"maybe the whole 'text size' menu could be removed and just add a single
menu entry to change the font
of how you see user's text, so they get it all in one window (the same
button is in the prefs window)"
From your quote above, I think the current code i submitted implemented
that. However, you might probably be right if the person who first
implemented this window purposedly left out the size column because of
something. Therefore, I will wait for more information from you :)
Meanwhile, I'll do as you suggested, modifying the menu entry to show font
sizes instead of just +1 +2 ... etc... Thanks...
Regards,
sakesashimi
On 3/20/07, Youness Alaoui <[EMAIL PROTECTED]> wrote:
>
> Hi Sake,
> Like vivia said, the best way to send a patch is to save your work, do a
> 'svn update', then 'svn diff', and send
> us the diff result...
> Now, I'm sorry but I don't understand what you did... with this fix...
> it has nothing to do with what was
> asked... Maybe you forgot to send the diff for the chatwindow.tcl file
> or something.. or maybe you
> misunderstood..
> humm.. ok, I just reread the forum thread and you're right, I'm the one
> who misunderstood.. I was actually
> refering to the line in the post that says :
> "The menu view->text size, isn't user friendly"
> referring to the menu of the chatwindow, wich is why I told you to look
> at the CreateTextSizeMenu in
> chatwindow.tcl...
> Now I understand your diff a bit better.. but I' masking myself, why the
> -nosizes 1 was put there in the first
> place ? that's what you should ask yourself.. see who added it and when
> and for what reason, maybe the sizes
> column caused a bug or something.. I'll try to find that answer for you,
> in the meantime, you could try changing
> the chat window's menus so it could be more user friendly (now it's +1,
> +2, etc.. maybe font sizes would be
> better).. maybe the whole 'text size' menu could be removed and just add
> a single menu entry to change the font
> of how you see user's text, so they get it all in one window (the same
> button is in the prefs window)
>
> KaKaRoTo
>
>
> On Tue, Mar 20, 2007 at 02:20:32AM -0400, Sake Sashimi wrote:
> > Hi Kakaroto,
> >
> > I manage to finish the first TODO (better usable menu options for
> changing
> > text size)
> >
> > http://www.amsn-project.net/forums/viewtopic.php?t=2827 - better
> usable menu
> > options for the change text size...
> >
> > Basically, I modified gui.tcl file within choose_font and change_font
> > procs. Right now, if user click the 'change font' button in the chat
> > window, and also the two 'change buttons' in Preference->Appearance, a
> > change font window with additional font size list column will
> appear. User
> > can change text size by selecting the size number on the list. The
> change
> > will be persistent.
> >
> > I have tested it thoroughly, and it works consistently. The only
> thing is
> > that, if you ever notice, some fonts have a range sizes in which if
> you
> > change the size within that range, the size of the font does not
> change (for
> > example: for font 'times', size between 19 to 22 does not actually
> change
> > the size of the font, ie: size 19 to 22 is the same size for font
> 'times').
> > I am sure this is not amsn issue. it probably tcl issue.
> >
> > I am not too familiar about the process of submitting the code. I
> attached
> > the file that I modified in this email. I hope my change is
> acceptable :)
> > Please let me know if there is a specific way to send fixes.
> >
> > Thank you,
> > sakesashimi
>
>
> >
> -------------------------------------------------------------------------
> > Take Surveys. Earn Cash. Influence the Future of IT
> > Join SourceForge.net 's Techsay panel and you'll get the chance to
> share your
> > opinions on IT & business topics through brief surveys-and earn cash
> >
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> > _______________________________________________
> > Amsn-devel mailing list
> > Amsn-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/amsn-devel
>
>
> -------------------------------------------------------------------------
>
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share
> your
> opinions on IT & business topics through brief surveys-and earn cash
>
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> Amsn-devel mailing list
> Amsn-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/amsn-devel
>
Index: chatwindow.tcl
===================================================================
--- chatwindow.tcl (revision 8265)
+++ chatwindow.tcl (working copy)
@@ -1436,15 +1436,13 @@
# of the chat window
#
proc CreateTextSizeMenu { menu } {
+ set basesize [lindex [::config::getGlobalKey basefont] 1]
set textsizemenu $menu.textsize
menu $textsizemenu -tearoff 0 -type normal
- foreach size {" 8" " 6" " 4" " 2" " 1" " 0" " -2" " -4" } {
- if {$size > 0 } {
- $textsizemenu add command -label "+$size"
-command "change_myfontsize $size"
- } else {
- $textsizemenu add command -label "$size"
-command "change_myfontsize $size"
- }
+ foreach size {" 4" " 5" " 6" " 7" " 8" " 9" "10" "11" "12" "13"
"14" "15" "16" "17" "18" "19" "20" "21" "22" "23" "24" } {
+ $textsizemenu add command -label "$size" -command
"change_myfontsize [expr {$size - $basesize} ]"
+
}
return $textsizemenu
Index: gui.tcl
===================================================================
--- gui.tcl (revision 8265)
+++ gui.tcl (working copy)
@@ -3789,7 +3789,7 @@
return
}
- set selected_font [SelectFont .fontsel -parent $parent -title $title
-font $initialfont -initialcolor $initialcolor -nosizes 1]
+ set selected_font [SelectFont .fontsel -parent $parent -title $title
-font $initialfont -initialcolor $initialcolor]
return $selected_font
}
@@ -3803,7 +3803,8 @@
#Get current font configuration
set fontname [lindex [::config::getKey $key] 0]
- set fontsize [expr {$basesize + [::config::getKey textsize]}]
+ set fontsize [expr {$basesize + [::config::getKey textsize] } ]
+
set fontstyle [lindex [::config::getKey $key] 1]
set fontcolor [lindex [::config::getKey $key] 2]
@@ -3819,6 +3820,7 @@
}
set sel_fontfamily [lindex $selfont 0]
+ set sel_fontsize [lindex $selfont 1]
set sel_fontstyle [lrange $selfont 2 end]
@@ -3830,7 +3832,7 @@
::config::setKey $key [list $sel_fontfamily $sel_fontstyle $selcolor]
- change_myfontsize [::config::getKey textsize]
+ change_myfontsize [expr {$sel_fontsize - $basesize} ]
}
#///////////////////////////////////////////////////////////////////////
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Amsn-devel mailing list
Amsn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/amsn-devel
