Is there any reasoning behind the fact that unarchive module using zip 
never checks the destination if the files already exists. This is quite 
inconvenient when extracting very large files.

I understand that tar has --diff argument and it makes it easy to use, but 
It could be fairly trivial to implement this with python zipfile. It is 
already in in use in unarchive.py:

https://github.com/ansible/ansible-modules-core/blob/devel/files/unarchive.py

We could use ZipFile.infolist() to get filenames and file sizes and check 
them against destination. There's already a method which decides that zip 
files are always not unarchived:


def is_unarchived(self, mode, owner, group):
  return dict(unarchived=False)


 I could definitely contribute if this sounds plausible.

- t-m

-- 
You received this message because you are subscribed to the Google Groups 
"Ansible Project" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/ansible-project/283e3ddc-d1a6-4885-a218-61b62fbf9e00%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to