On Tue, 2 Feb 2016, Tuomas-Matti Soikkeli wrote:

I believe it's because zip doesn't support it like tar does. So I suppose
there is no fix for that other than manually comparing the contents with
python ZipFile api. Unfortunately zip lacks most of the unixy features
which tar provides like user/group modes, modification date and so on.

So the final question is do we choose convenience over control? Just check
file sizes from headers and don't extract if matches. Is this reasonable or
unacceptable?

it might be easier to figure out
why creates= is too slow for you and fixing that.

I implemented exactly what youneeded.

Could you test the following pull-request and provide feedback ?

    https://github.com/ansible/ansible-modules-core/pull/3307

Next I would like to make unarchive idempotent completely, using native zipfile and tarfile modules. A lot of the code to make zip support idempotent can simply be reused, however it also means we have to implement whatever functionality tar has ourselves (with the added benefit, that this functionality will work identically for all other archive formats).

So first things first, improve the zip support as-is.

More information in the PR description linked above.

--
Dag

Reply via email to