I've been working on a slightly different angle here, trying to avoid thread exit, and to allow threads to range usefully between min and max.
The current code in CVS has a number of problems which lead to the server not creating more threads when there are queued requests and the number of threads is below max (sometimes below min!). Now my test code has solved most of these issues. 1. threads go up very quickly to with load increase. 2. threads go down when load goes down (if queue is kept empty) to slightly below concurrency. 3. if maxthreads is lowered, threads slowly go down to meet the new value. There are still a few things I'd like to look at, so I'll hold off on any commit for now. tom jackson On Monday 22 October 2007 16:04, Gustaf Neumann wrote: > Andrew Piskorski schrieb: > >> My only point here was that I'm going to stop looking at the timeout > >> parameter, and timed out threads as an issue. If threads timeout, the > >> number of threads in a threadpool will drop below minthreads, usually to > >> zero. > > > > But isn't that a bug? If not, just what is "minthreads" supposed to > > really mean? > > you are right, if someone specified minthreads, they should be maintained. > i have added an additional condition to the thread recreation to > maintain the specified minimal number of threads. > maybe Tom has something more sophisticated in mind. this is again > a minimal invasive fix, similar to the fix for assuring the processing > of the queued requests, when all connection threads exit. > > for more details, see: > http://aolserver.cvs.sourceforge.net/aolserver/aolserver/nsd/queue.c?view=l >og > > best regards > -gustaf neumann > > > -- > AOLserver - http://www.aolserver.com/ > > To Remove yourself from this list, simply send an email to > <[EMAIL PROTECTED]> with the body of "SIGNOFF AOLSERVER" in the > email message. You can leave the Subject: field of your email blank. -- AOLserver - http://www.aolserver.com/ To Remove yourself from this list, simply send an email to <[EMAIL PROTECTED]> with the body of "SIGNOFF AOLSERVER" in the email message. You can leave the Subject: field of your email blank.
