On Friday 26 October 2007 17:27, Gustaf Neumann wrote: > i was not able to recreate the crash that you have reported in the other > mail. > However, with ab with small files and pure aolserver (without openacs), > i could verify that some of the counters were wrong. The decision to > create a thread or not in NsQueueConn() was based on a counter that > was wrong, since it did not take into account that some more threads > are already starting in the background. To address this issuess, there > are now two additional variables, namely starting (# of currently > starting threads) and waiting (# of threads in a cond wait). > It would be great if you could test this code again in your environment.
I'm not sure if you are disputing the bug or not, but I'm somewhat tired of this. I've been testing various patches for the last few weeks in addition to my own code. It seems that everyone knows I've been working on this for a few weeks or more, and everytime I identify a problem, a new patch with a new problem is placed into CVS. Each time I try to point out that this isn't a simple issue, but patches show up with a one dimensional solution or no testing to back them up. I'll commit my code over the weekend replacing the current code. My fix will be a bug fix. The bugs are these: 1. unable to respond to load changes (up and down) 2. unable to respond to configuration changes (up and down) 3. poor, incorrect or missing synchronization code. 4. queued doesn't reflect current queued requests. 5. threads exit unnecessarily on timeout, then new threads to replace 6. current patches cause signal 11 under easily repeated conditions. If anyone wants to stick to the current code, let me know, and I'll just keep my changes here. My code is well tested with small, large and very large files, low, and high maxconns, low-high threads, and also using [ns_conn channel] to send the sock to a worker thread. I run the queue under continuous loads and vary the threads/maxconns to see the response. tom jackson -- AOLserver - http://www.aolserver.com/ To Remove yourself from this list, simply send an email to <[EMAIL PROTECTED]> with the body of "SIGNOFF AOLSERVER" in the email message. You can leave the Subject: field of your email blank.
