Hi Imesh, *I think it would be better if we can first move the secure vault code from carbon-kernel repository to the new repository with commit history and then apply the changes you have done. Otherwise, we will loose all history.*
+1. We should move the secure vault out of carbon kernel preserving the commit history On Fri, Mar 10, 2017 at 3:54 PM, Imesh Gunaratne <[email protected]> wrote: > Hi Vidura, > > I think it would be better if we can first move the secure vault code from > carbon-kernel repository to the new repository with commit history and then > apply the changes you have done. Otherwise, we will loose all history. > > I had a chat with Lakshman on this and it seems like he has extracted all > secure-vault related code into a new component and sent a PR [1] but it has > not been merged. > > IMO we would need to do following: > > - First, fix conflicts and merge [1]. This would bring all secure > vault related code to a new component/folder. > - Then move above folder to [2] using a PR-X > - Once the PR-X is merged, apply your changes on top of it. > > [1] https://github.com/wso2/carbon-kernel/pull/1266 > [2] https://github.com/wso2/carbon-secvault > > Thanks > > On Mon, Mar 6, 2017 at 12:15 PM, Niranjan Karunanandham <[email protected] > > wrote: > >> Hi Vidura, >> >> On Mon, Mar 6, 2017 at 11:52 AM, Imesh Gunaratne <[email protected]> wrote: >> >>> On Fri, Mar 3, 2017 at 12:00 PM, Thusitha Thilina Dayaratne < >>> [email protected]> wrote: >>> >>>> Rather than having a separate repo for utils I'll look into the >>>> possibility of moving that to a separate component (same level as core) >>>> without having cyclic dependencies. If that is possible then we can pack >>>> that as a new feature or core feature itself. Otherwise lets move that to a >>>> separate repo. >>>> >>>> Thusitha has done this change in the following PR: >>> https://github.com/wso2/carbon-kernel/pull/1318 >>> >> Once this PR is merged, we need to add the support to provide an API >> which can return the current config folder for a particular runtime. >> >> >>> >>> >>> Thanks >>> >>> -- >>> *Imesh Gunaratne* >>> Software Architect >>> WSO2 Inc: http://wso2.com >>> T: +94 11 214 5345 M: +94 77 374 2057 <+94%2077%20374%202057> >>> W: https://medium.com/@imesh TW: @imesh >>> lean. enterprise. middleware >>> >>> >> Regards, >> Nira >> >> -- >> >> >> *Niranjan Karunanandham* >> Associate Technical Lead - WSO2 Inc. >> WSO2 Inc.: http://www.wso2.com >> >> > > > -- > *Imesh Gunaratne* > Software Architect > WSO2 Inc: http://wso2.com > T: +94 11 214 5345 M: +94 77 374 2057 <+94%2077%20374%202057> > W: https://medium.com/@imesh TW: @imesh > lean. enterprise. middleware > > -- Best Regards, *Vidura Nanayakkara* Software Engineer Email : [email protected] Mobile : +94 (0) 717 919277 Web : http://wso2.com Blog : https://medium.com/@viduran <http://wso2.com/> Twitter : http://twitter.com/viduranana LinkedIn : https://lk.linkedin.com/in/vidura-nanayakkara <http://wso2.com/>
_______________________________________________ Architecture mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
