Patch looks good, assuming you can build eba-maven-plugin using the init profile successfully.
Does it make sense for us to release the eba-maven-plugin separately, so that user doesn't have to build aries using the init profile first? Lin On Wed, Mar 24, 2010 at 1:40 PM, Alan D. Cabrera <[email protected]> wrote: > I did attach a file. > > Index: pom.xml > =================================================================== > --- pom.xml (revision 927124) > +++ pom.xml (working copy) > @@ -38,18 +38,6 @@ > > <modules> > <module>parent</module> > - <module>eba-maven-plugin</module> > - <module>testsupport</module> > - <module>util</module> > - <module>blueprint</module> > - <module>jndi</module> > - <module>transaction</module> > - <module>web</module> > - <module>application</module> > - <module>jmx</module> > - <module>jpa</module> > - <module>spi-fly</module> > - <module>samples</module> > </modules> > > <build> > @@ -63,4 +51,37 @@ > </plugins> > </build> > > + > + <profiles> > + <profile> > + <id>default</id> > + <activation> > + <activeByDefault>true</activeByDefault> > + </activation> > + <modules> > + <module>testsupport</module> > + <module>util</module> > + <module>blueprint</module> > + <module>jndi</module> > + <module>transaction</module> > + <module>web</module> > + <module>application</module> > + <module>jmx</module> > + <module>jpa</module> > + <module>spi-fly</module> > + <module>samples</module> > + </modules> > + </profile> > + > + <profile> > + <id>init</id> > + <activation> > + <activeByDefault>false</activeByDefault> > + </activation> > + <modules> > + <module>eba-maven-plugin</module> > + </modules> > + </profile> > + > + </profiles> > </project> > > On Mar 24, 2010, at 11:04 AM, Lin Sun wrote: > >> I think using profiles is fine or perhaps we can move the >> eba-maven-plugin to its own tree/build and release the >> eba-maven-plugin separately (which seems reasonable). >> >> P.S. did you intend to attach a file? anyway I don't see it. >> >> Lin >> >> On Wed, Mar 24, 2010 at 12:55 PM, Alan D. Cabrera <[email protected]> >> wrote: >>> >>> >>> Here's a possible fix using profiles. WDYT? >>> >>> >>> Regards, >>> Alan >>> >>> On Mar 24, 2010, at 10:45 AM, Lin Sun wrote: >>> >>>> Hi >>>> >>>> I think I ran into similar issues yesterday when I tried to build with >>>> a clean .m2 repo. I remember I had to manually build the >>>> default-parent, parent, then eba-plugin to get around this. We'll >>>> have to make sure we can build aries with a clean .m2 repo before we >>>> release. >>>> >>>> Lin >>>> >>>> On Wed, Mar 24, 2010 at 12:39 PM, Alan D. Cabrera <[email protected]> >>>> wrote: >>>>> >>>>> I'm on a new tower and I tried to do a fresh build and it fails because >>>>> of a >>>>> missing EBA plugin. I try to build the EBA plugin and it fails because >>>>> it's >>>>> missing a parent. >>>>> >>>>> Shouldn't we control this build process via profiles at the SVN root? >>>>> >>>>> >>>>> Regards, >>>>> Alan >>>>> >>>>> >>> >>> > >
