Le mercredi 19 septembre 2012 20:58:07 Stéphane Magnenat a écrit : > On 19/09/12 14:21, Philippe Rétornaz wrote: > > Hi > > > >> I have applied your patch, tell me if you need something else. > > > > It works fine, you can have a look at the code in > > https://github.com/retornaz/aseba/commits/socketcan > > > > Successfully tested on an omap3 board with a sja1000 chip ! > > Looks good. Just some notes: > > - */CMakeLists.txt: you have added it to the source file list, I would > have made a small static library and liked all binaries with it, it > seems cleaner. Any reason not to do it?
I'm far from being a cmake master. So I did what worked at first shot. I will try your solution :) > - socketcan.cpp: indentation and style is not Aseba-standard, but I can > live with yours for this file. You are not very verbose either, but I > guess I'll have to live with it as well. However, you should at least > document the parameters this stream accepts (if and baud (ignored?, > future proof?)). I will have to clean the code before merge. This is more an RFC than a request for merge ! Thanks ! Philippe _______________________________________________ Aseba-dev mailing list Aseba-dev@gna.org https://mail.gna.org/listinfo/aseba-dev
