----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3551/#review11970 -----------------------------------------------------------
Ship it! /branches/12/apps/app_agent_pool.c <https://reviewboard.asterisk.org/r/3551/#comment21882> Minor nitpick: update the documentation for ast_bridge_destroy to note that passing a cause of 0 is equivalent to AST_CAUSE_NORMAL_CLEARING. - Matt Jordan On May 22, 2014, 5:30 p.m., rmudgett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3551/ > ----------------------------------------------------------- > > (Updated May 22, 2014, 5:30 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23499 > https://issues.asterisk.org/jira/browse/ASTERISK-23499 > > > Repository: Asterisk > > > Description > ------- > > Improvements to the agent pool functionality. > > * AgentRequest no longer hangs up the caller if the agent fails to connect > with the caller. It now continues in the dialplan. > > * AgentRequest returns AGENT_STATUS set to NOT_CONNECTED if the agent failed > to connect with the call. Most likely because the agent did not acknowledge > the call in time or got disconnected. > > * The agent alerting play file configured by the agent.conf custom_beep > option can now be disabled by setting the option to an empty string. The > agent is effectively alerted to a call presence when MOH stops. > > * Fixed bridge reference leak when the agent connects with a caller. > > > Diffs > ----- > > /branches/12/apps/app_agent_pool.c 414470 > /branches/12/CHANGES 414470 > > Diff: https://reviewboard.asterisk.org/r/3551/diff/ > > > Testing > ------- > > Initiated an AgentRequest where the agent did the following: > * Did nothing and got automatically logged off. Before the caller would be > hungup. Now the caller returns to the dialplan with AGENT_STATUS set to > NOT_CONNECTED. > * Hungup. Before the caller would be hungup. Now the caller returns to the > dialplan with AGENT_STATUS set to NOT_CONNECTED. > * Acks the call with the wrong digit. Before the caller would be hungup. > Now the caller returns to the dialplan with AGENT_STATUS set to NOT_CONNECTED. > * Acks the call correctly. Before the conversation bridge would be leaked > and remain in the stasis cache for "bridge show all" to display. Now it > doesn't. > > > Thanks, > > rmudgett > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
