On Mon, Nov 17, 2008 at 03:35:07PM +0800, Xu, Martin wrote:
> Hi bob??
> Please review below patch which has been modified according to your comments.
Thanks, looks a lot better. I still have a few minor comments:
> +static void
> +set_beacon_filter(struct ieee80211_hw *hw, bool enable)
> +{
[...]
> + return;
> +}
Please don't use 'return' for void functions.
> +static void ath5k_bss_info_changed(struct ieee80211_hw *hw,
> + struct ieee80211_vif *vif,
> + struct ieee80211_bss_conf *bss_conf,
> + u32 changes)
> +{
> + struct ath5k_softc *sc = hw->priv;
> + if (changes & BSS_CHANGED_ASSOC) {
> + mutex_lock(&sc->lock);
> + sc->assoc = bss_conf->assoc;
> + if (sc->opmode == NL80211_IFTYPE_STATION) {
> + if (sc->assoc)
> + set_beacon_filter(hw, 1);
> + else
> + set_beacon_filter(hw, 0);
No need for test:
set_beacon_filter(hw, sc->assoc);
> + }
> + mutex_unlock(&sc->lock);
> + }
> + return;
ditto above comment
Thanks,
Bob
--
Bob Copeland %% www.bobcopeland.com
_______________________________________________
ath5k-devel mailing list
[email protected]
https://lists.ath5k.org/mailman/listinfo/ath5k-devel
