Hi Martin,
> From: Martin Xu <[EMAIL PROTECTED]>
> Subject: disable beacon filter when station is not associated with any AP.
>
> Ath5k driver has too many interrupts per second at idle
> http://bugzilla.kernel.org/show_bug.cgi?id=11749
>
> Signed-off-by: Martin Xu <[EMAIL PROTECTED]>
Thanks for the cleanups. I don't have any objections to the patch.
Anyone else want to weigh in?
Patch reproduced here:
>
> diff --git a/drivers/net/wireless/ath5k/base.c
> b/drivers/net/wireless/ath5k/base.c
> index 34cd1a4..37da7cc 100644
> --- a/drivers/net/wireless/ath5k/base.c
> +++ b/drivers/net/wireless/ath5k/base.c
> @@ -241,6 +241,10 @@ static int ath5k_get_tx_stats(struct ieee80211_hw *hw,
> static u64 ath5k_get_tsf(struct ieee80211_hw *hw);
> static void ath5k_reset_tsf(struct ieee80211_hw *hw);
> static int ath5k_beacon_update(struct ath5k_softc *sc, struct sk_buff *skb);
> +static void ath5k_bss_info_changed(struct ieee80211_hw *hw,
> + struct ieee80211_vif *vif,
> + struct ieee80211_bss_conf *bss_conf,
> + u32 changes);
>
> static struct ieee80211_ops ath5k_hw_ops = {
> .tx = ath5k_tx,
> @@ -2952,7 +2956,7 @@ static void ath5k_configure_filter(struct ieee80211_hw
> *hw,
> sc->opmode != NL80211_IFTYPE_MESH_POINT &&
> test_bit(ATH_STAT_PROMISC, sc->status))
> rfilt |= AR5K_RX_FILTER_PROM;
> - if (sc->opmode == NL80211_IFTYPE_STATION ||
> + if ((sc->opmode == NL80211_IFTYPE_STATION && sc->assoc) ||
> sc->opmode == NL80211_IFTYPE_ADHOC ||
> sc->opmode == NL80211_IFTYPE_AP)
> rfilt |= AR5K_RX_FILTER_BEACON;
> @@ -3092,4 +3096,32 @@ ath5k_beacon_update(struct ath5k_softc *sc, struct
> sk_buff *skb)
>
> return ret;
> }
> +static void
> +set_beacon_filter(struct ieee80211_hw *hw, bool enable)
> +{
> + struct ath5k_softc *sc = hw->priv;
> + struct ath5k_hw *ah = sc->ah;
> + u32 rfilt;
> + rfilt = ath5k_hw_get_rx_filter(ah);
> + if (enable)
> + rfilt |= AR5K_RX_FILTER_BEACON;
> + else
> + rfilt &= ~AR5K_RX_FILTER_BEACON;
> + ath5k_hw_set_rx_filter(ah, rfilt);
> + sc->filter_flags = rfilt;
> +}
>
> +static void ath5k_bss_info_changed(struct ieee80211_hw *hw,
> + struct ieee80211_vif *vif,
> + struct ieee80211_bss_conf *bss_conf,
> + u32 changes)
> +{
> + struct ath5k_softc *sc = hw->priv;
> + if (changes & BSS_CHANGED_ASSOC) {
> + mutex_lock(&sc->lock);
> + sc->assoc = bss_conf->assoc;
> + if (sc->opmode == NL80211_IFTYPE_STATION)
> + set_beacon_filter(hw, sc->assoc);
> + mutex_unlock(&sc->lock);
> + }
> +}
> diff --git a/drivers/net/wireless/ath5k/base.h
> b/drivers/net/wireless/ath5k/base.h
> index 06d1054..facc60d 100644
> --- a/drivers/net/wireless/ath5k/base.h
> +++ b/drivers/net/wireless/ath5k/base.h
> @@ -179,6 +179,7 @@ struct ath5k_softc {
>
> struct timer_list calib_tim; /* calibration timer */
> int power_level; /* Requested tx power in dbm */
> + bool assoc; /* assocate state */
> };
>
> #define ath5k_hw_hasbssidmask(_ah) \
> _______________________________________________
> ath5k-devel mailing list
> [email protected]
> https://lists.ath5k.org/mailman/listinfo/ath5k-devel
>
--
Bob Copeland %% www.bobcopeland.com
_______________________________________________
ath5k-devel mailing list
[email protected]
https://lists.ath5k.org/mailman/listinfo/ath5k-devel
