On Thu, Apr 22, 2010 at 11:54 AM, Akshay Lal <[email protected]> wrote: > Well previously, when the fsck ran on an unmounted file system and the file > system was dirty/corrupted in anyway, the fsck would throw an error (but fix > the file system '-fy'). This error would get logged in the > console/tests-specific log as an 'ERROR', but the overall test would pass. > Thats not really very non-intuitive and not correct (either) since you > ideally want the file system in a clean state after all the tests run. > Explicitly stating that a failure in an fsck run results in a test failure > seems like the right approach - I think.
That seems odd. I'd think the test level error handler would convert it. Greg - do you recall from refactoring that code? I'm suspicious of throwing a TestError from something that can be run from outside of a test. _______________________________________________ Autotest mailing list [email protected] http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
