> I suggested that Akshay put this here.  But if thats wrong, we need to
> look closer to figure out where it goes.
>
> What calls this code?  The only caller I see is
> partition.cleanup_after_test() which is called by
> partition.run_test_on_partition after job.run_test() is finished but
> still within the context of job.run_group().

I think that's the only checked in code, but a control file could
also use it, IIRC.

> Is it crazy of me to think that filesystem tests should be calling
> this directly within the context of a test if they want to depend on
> the error being flagged as a test problem.  Which either means that
> partition.run_test_on_partition probably needs to be reworked to make
> sure the fsck happens within run_test context or that the tests using
> it should explicitly call partition.fsck themselves when they want the
> fsck result to change the test outcome.

IIRC, The intent with this is that the test group would fail, and that
appears as the failure within status.log.
_______________________________________________
Autotest mailing list
[email protected]
http://test.kernel.org/cgi-bin/mailman/listinfo/autotest

Reply via email to