It would be nice if we didn't have to go add the fsck call to each test. Since the partitions module is used for all FS tests, having it there for use by all makes sense to me.
Curt On Wed, Apr 28, 2010 at 3:13 PM, Theodore Tso <[email protected]> wrote: > (Oops, hit "reply" instead of "reply to all") > > On Wed, Apr 28, 2010 at 6:12 PM, Theodore Tso <[email protected]> wrote: >> >> On Wed, Apr 28, 2010 at 6:05 PM, Martin Bligh <[email protected]> wrote: >>> >>> >> Fair enough. I still don't see why the group level code isn't catching >>> >> this. Are you saying that's because it's not a TestError? Or is >>> >> something >>> >> else broken? >>> > >>> > Well, the flip side of the Test* exceptions (according to our how to >>> > write a >>> > test docs) is that when someone raises them during a test they expect >>> > it to >>> > terminate the test; catching them in run_group would violate that >>> > expectation. We document raising TestError as the correct way to say >>> > "we're >>> > done here, log the test as an ERROR and move on". >>> >>> Mmm, my impression was that it wasn't a TestError currently though, so >>> should get caught in run_group? >> >> Should we perhaps move the fsck into the test? The whole point is that >> if the kernel has managed to corrupt the file system after running dbench, >> then we have a test failure. So arguably the fsck -f is part of the test. >> If fsck detects problems, then the test has failed. >> >> -- Ted >> >> > > -- > You received this message because you are subscribed to the Google Groups > "ext4-team" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/a/google.com/group/ext4-team/?hl=en. > _______________________________________________ Autotest mailing list [email protected] http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
