On 01/04/2011 02:15 PM, Lucas Meneghel Rodrigues wrote: > > I see an opportunity for us to do some cleanup on that and eliminate > bin. Now, we need a plan of migration, a carefully made patchset, and > tons of testing. Perhaps the entire contents of bin can be dropped into > client altogether, but that is not too symmetrical with common_lib. > > Ideas? >
Not suggesting that any of this get tackled now, but it's closely related so here it goes... I really don't like the '_lib' suffix in both 'autotest_lib' and 'common_lib'. IMHO this reads much better: from autotest.client.common import base_job than: from autotest_lib.client.common_lib import base_job Further playing devil's advocate to generate some brainstorm: shouldn't "autotest_lib.client" package simply be "autotest" when deployed/run on the client? I mean, all client code could be like this: from autotest.common import base_job Many python projects conform to setuptools defaults and separate library code from scripts, configuration, etc at the source root dir, such as (for project "bla"): bla bla/bla (or bla/lib/bla) bla/scripts bla/conf Currently autotest source root dir is a huge python module with miscellaneous content (configuration, documentation, etc) spread all over it. Maybe this is an opportunity to think about it, maybe an opportunity to plan a change... maybe (really maybe!) the time to do it! CR. _______________________________________________ Autotest mailing list [email protected] http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
