On Tue, Jan 4, 2011 at 10:19 AM, Cleber Rosa <[email protected]> wrote:
> On 01/04/2011 03:28 PM, Eric Li(李咏竹) wrote: > > +1 with John. > > > > Renaming autotest_lib to autotest will have a hugely impact to > > ChromeOS test automation project, since we need to go over through all > > test cases to change the import statement... > > > > Eric > > > > I guess we're all aware of the impact, but we should remember that this > would be, as Lucas said, mostly a mechanical change, very easy to > replicate on site specific tests. Again, no change in semantics, just > the module name. > > But that's me, who does *not* maintain site specific tests, saying that. > > Changing the name of server/autotest.py is more subtle though, since it's an implicit variable exposed to every control file. If it wasn't for that the change would be pretty much mechanical since not much references the autotest_lib name other than import statements. I suppose it's not technically necessary to rename server/autotest.py, since if all imports from autotest_lib are "from X import Y" style imports than the naming conflict isn't actually a problem. It's just that at the time we were trying to name the top-level module we preferred to avoid the potential for trouble by avoiding a name collision. > CR. > _______________________________________________ > Autotest mailing list > [email protected] > http://test.kernel.org/cgi-bin/mailman/listinfo/autotest >
_______________________________________________ Autotest mailing list [email protected] http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
