On 03/20/2012 08:17 AM, Lucas Meneghel Rodrigues wrote: > On 03/20/2012 06:47 AM, Alex Jia wrote: >> Hello Lucas, >> I want to know how to define libvirt_vm.py scope, it seems the module is >> only used for VMs related operations, you know we can also use virsh to >> manage storage pool/volume, network, and interface, etc. if I plan to >> add them into libvirt-autotest, libvirt_vm module should be a right >> place, right? but its naming is inappropriate... > > Since we're growing that part of the code, I believe a pretty sensible > solution is to split the code that deals with virsh in a new file called > virsh.py, and then import it on libvirt_vm.py, and of course make all > necessary changes. > > Cheers, > > Lucas
This topic has been on my mind, so I'll share... My thinking was the virsh* stuff should just go into the libvirt_monitor module. The module's already there (but not used/working), and most of the virsh* stuff we're doing is more-or-less analogous to what happens in the KVM monitor module (though different mechanisms). What about ripping apart the disused libvirt_monitor module, moving all the virsh stuff there, and putting it to use? This would avoid adding another file to the tree, and keep the module naming consistent. Thoughts? -- Chris Evich, RHCA, RHCE, RHCDS, RHCSS Quality Assurance Engineer e-mail: cevich + `@' + redhat.com o: 1-888-RED-HAT1 x44214 _______________________________________________ Autotest mailing list Autotest@test.kernel.org http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
