On 03/21/2012 01:11 PM, Alex Jia wrote: > We indeed should keep the module naming consistent, but I think it has > 2 layers meaning, the one is module naming should be consistent; the > other is related module should depict similar function, for example, > > kvm_monitor.py: Interfaces to the QEMU monitor > kvm_vm.py: Utility classes and functions to handle Virtual Machine creation > using qemu. > > For libvirt-autotest: > libvirt_monitor.py: (we haven't any definition in here) > libvirt_vm.py: Utility classes and functions to handle Virtual Machine > creation using libvirt. > > For libvirt, you know it hasn't a monitor concept like qemu, virsh has only a > qemu-monitor-command > command to directly send qemu command to guest bypass libvirt, if we put > all of virsh commands into libvirt_monitor module, I don't know how to > define the module function. > > In addition, libvirt has also some host related virsh commands such as > 'interface' group > command, libvirt uses netcf library to directly mananger host network > interface, > it's unrelated with guest. > > Lucus and Chris, thanks for your suggests.
I guess the best thing here is to remove libvirt_monitor.py altogether and introduce a virsh.py file, and call it a day. _______________________________________________ Autotest mailing list Autotest@test.kernel.org http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
