On 03/28/2012 06:23 AM, Alex Jia wrote: >> I guess the best thing here is to remove libvirt_monitor.py altogether >> and introduce a virsh.py file, and call it a day. > I haven't seen other feedback by now, if it's a final solution, I will > commit patches to > change these or others want to do it, also okay for me: > > 1. remove libvirt_monitor.py > 2. introduce a virsh.py then move all of virsh wrapper into it > 3. also need to change previous cases to follow these modification > > Please let me know early if you have a better suggestion. > > Regards, > Alex
I was thinking very broadly of the definition of 'monitor', I know it's not an exact fit. Virsh.py is fine by me also. My preference would be that test-module code not use it directly, but go through the VM class. That will let us better weather underlying virsh changes and compatibility issues. However, getting the code moved to a new module is the first step, and it will un-cluter libvirt_vm.py quite a bit. Thanks! -- Chris Evich, RHCA, RHCE, RHCDS, RHCSS Quality Assurance Engineer e-mail: cevich + `@' + redhat.com o: 1-888-RED-HAT1 x44214 _______________________________________________ Autotest mailing list Autotest@test.kernel.org http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
