As Marian Buschsieweke wrote: > the attached patch fixes an incorrect return statement: Apparently old GCC > versions implicitly casted "false" to "NULL", which no longer is the case. So > the "return false;" statement in jtagrw.cc:134 in function > > uchar *jtag1::jtagRead(unsigned long addr, unsigned int numBytes) > > should be replaced by "return NULL;"
See bug report #24 (filed just recently) > Also, there is a lot of inconsistent use of tabs and spaces for indent. Maybe > running astyle, uncrustify, or whatever of the code would be a good idea? ;-) Changing whitespace just for the purpose of changing it is generally not a good idea. It potentially obfuscates real code changes later on. That doesn't mean maintaining a consistent style is a bad idea, but I wouldn't want to commit changes just for that. -- cheers, Joerg .-.-. --... ...-- -.. . DL8DTL http://www.sax.de/~joerg/ Never trust an operating system you don't have sources for. ;-) ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ avarice-user mailing list avarice-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/avarice-user
