On Thursday, 6. September 2001 12:36, Zdenek Kabelac wrote:
> On Thu, Sep 06, 2001 at 12:30:37AM +0200, Felix Buenemann wrote:
> > Hi,
> >
> > I'm kinda disappointed to see that avifile is using my OggVorbis code
> > from MPlayer without giving me a single line of credit or not even a
> > notice that the code has been take from the mplayer project.
> > In the ChangeLog it only mentions some 3 magic numbers take from mplayer
> > which seems to refer to the three ogg_packet headers which size and
> > themselves are stored in the data chunk of the WAVEFORMATEXTENSIBLE
> > struct.
>
> At the first place - this code is being still developed - at the
> second only the header parsing is taken from mplayer code - and thats
> just because I couldn't find doc elsewhere - I'll specificaly add
> comment to each line if you wish - moreover usage of WAVEFORMATEXTENSIBLE
> was already made by me over the weekend - I had the vorbis plugin
> ready on sunday - except I had to add those three headers
> by copying them to create normal valid vorbis stream.
Hint: WAVEFORMATEXTENSIBLE stuff was discovered by me talking with Ingo (ok I
first always though WAVEFORMATEX was the short form for WAVEFORMATEXTENSIBLE,
until Ingo noticed me that our (avifiles) mmreg.h didn't contain a
WAVEFORMATEXTENSIBLE struct and send me correct headers and discribed the
stuff to me. I told Arpi and Arpi told you, IMHO, correct me if I'm wrong ;)
> (So it could really play only that Coyote sample file :)
> (btw you might see those headers at the bottom of the file)
>
> Convertor is based on standard example code available in vorbis
> library (we have obviously both made cut&paste copy from their source)
hmm obviously to me I've done copy and paste from their decoder_example.c and
you copy and pasted that modified example code from mplayer sources, as one
can see from the printfs (now couts), which aren't existent in original
decoder_example or have other text.
BUT ok, I don't want to flame, let's stop this here!
>
> > Of course both mplayer and avifile are opensource projects so it's ok to
> > share source, but it's part of an developers etiquette to mark code taken
> > from other sources with it's origin as it's for example done in mplayers
> > documentation under the Authors section.
>
> Well - I'm doing these things and I'll surely add your name there - but
> maybe you could survive couple days - it has been commited just two days
> ago!
hmm, Gabucino announced MPlayer OggVorbis support before even I finished it
=) might have been some kind of misunderstanding anyways :)
>
> > It took me several days of hard work to implement Ogg/Vorbis support in
> > MPlayer so maybe that makes clear why I'm angry about this.
>
> I've spent two days with this myself - so you are not THE ONLY ONE!
If you were as puzzled as I, when you started that stuff no wonder...
Btw. if you still have QUestions about the stuff contact Ingo Ralf Blum
(Ingo) on irc.openprojects.net, he was very helpfull to me.
>
> > Btw. one can clearly identify that avifiles' code is taken from MPlayer
> > by simply taking a look at the info/debug messages used which are
> > strangely similiar to mine ;-)
>
> Yes - as I said header parsing is taken from mplayer as I have no
> idea from where else could I get such info. As this format is not
> documented anywhere - in my eyes its broken - and moreover I do not
> know about any tool which would create such stream...
nandub can multiplex oggvorbis with avi, but the headers it produces are
broken, that'S why seeking doesn't work. Playback is done by the MediaXW
dshow codecs (former ZoranNT FreeCodecs).
>
> > So a note about my work in the credits/whatever would make me happy again
> > :)
>
> Sure I'll check if I could add more lines :)
--
Best Regards,
Atmos
_____
World Domination, Fast!
- MPlayer Enterprises
_______________________________________________
Avifile mailing list
[EMAIL PROTECTED]
http://prak.org/mailman/listinfo/avifile
