On Mon, Apr 16, 2012 at 12:50 PM, Tuukka Verho <[email protected]> wrote:
> Ok. But please change the variable names, the original ones were confusing.

Sure -- which ones are confusing? They seem straightforward to me:

[abc]Trans: Translation vector along the a, b, or c axis
curImage: Vector pointing to the current translational image of the atoms/bonds

What would you suggest instead?

> And there's no need to calculate endPos-startPos again each time.

Good point, I'll make that change.

> With up to 3 clipping planes there are so many possibilities and corner
> cases that it is virtually impossible to avoid all artifacts. We just have
> to settle how many cases we want to cover (we don't want to end up in a
> situation where 90% of drawing code in Avogadro is related to this). I was
> actually a bit unsure whether drawing those "isolated" bond segments is a
> good idea because they often end up being clipped in complicated ways.
>
>> Maybe Avogadro 2.0 painters could have a set of clipping planes so
>> that we could more easily draw these structures? Then we could just
>> use native GL clipping and emulate it somehow for the other
>> paintdevices...
>
> I would vote for this option...

I think for now we should add an option to the bsdyengine settings
widget that will allow users to switch off isolated segment rendering,
or periodic bonding entirely. I can work on this later if no one gets
to it before I have time.

Dave

------------------------------------------------------------------------------
For Developers, A Lot Can Happen In A Second.
Boundary is the first to Know...and Tell You.
Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
http://p.sf.net/sfu/Boundary-d2dvs2
_______________________________________________
Avogadro-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/avogadro-devel

Reply via email to