On Mon, Apr 16, 2012 at 12:56 PM, Marcus D. Hanwell <[email protected]> wrote: > Is this going into a specialized plugin, or straight into bsdyengine? > I didn't look at the code, but it seems pretty specialized and I > wondered what (if any) impact this would have where there is no > periodic boundary.
I'll save you the trouble of digging through the patch ;-) https://github.com/dlonie/avogadro/blob/ENH_intercell_bonds/libavogadro/src/engines/bsdyengine.cpp#L150 If there's no unit cell defined, the bonds are rendered as usual. Otherwise each bond is shortened if needed, and tested to see if it intersects any face of the plane. >> Maybe Avogadro 2.0 painters could have a set of clipping planes so >> that we could more easily draw these structures? Then we could just >> use native GL clipping and emulate it somehow for the other >> paintdevices... >> >> I would vote for this option... >> > I think this would be reasonable, and I think virtually all rendering > engines have some form of clipping support that we could map to. Great, should we slot this in for 2.0, or should we go ahead and add it now? I think we could do it without any API breaks. My only concern with this approach is that it won't close off the cylinders, leading to odd backface culling artifacts. Dave ------------------------------------------------------------------------------ For Developers, A Lot Can Happen In A Second. Boundary is the first to Know...and Tell You. Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! http://p.sf.net/sfu/Boundary-d2dvs2 _______________________________________________ Avogadro-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/avogadro-devel
