[
https://issues.apache.org/jira/browse/AVRO-134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thiruvalluvan M. G. updated AVRO-134:
-------------------------------------
Attachment: AVRO-134.patch
Here is a patch with the following changes:
- DataFileWriter encodes a codec "raw" into the data file
- DataFileReader checks for a codec with value "raw". If not found it throws
an exception.
- I've refactored the constants used in DataFileReader and DataFileWriter
into a separate class DataFileConstants. It should ideally be a Java interface.
But checkstyle doesn't like constants-only interfaces. It needs at least one
method.
- I've made the corresponding changes to python code as well.
- Changed the documentation to reflect the change
> Mismatch between the spec and implementation of metadata blocks in files
> ------------------------------------------------------------------------
>
> Key: AVRO-134
> URL: https://issues.apache.org/jira/browse/AVRO-134
> Project: Avro
> Issue Type: Bug
> Reporter: Thiruvalluvan M. G.
> Attachments: AVRO-134.patch
>
>
> The spec says there are three keys in metadata blocks - schema, count and
> _codec_. But the code in DataFileWriter adds schema, count and _sync_. The
> sync field is used by the DataFileReader. We need to do the following:
> - Add the key sync in the specification.
> - Either drop the key codec in the specification or add code to support
> codec in DataFileReader/DataFileWriter. If we decide to have codec, we need
> to also publish in the spec the list of supported codecs with their names to
> use in the metadata block.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
