[
https://issues.apache.org/jira/browse/AVRO-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762695#action_12762695
]
Doug Cutting commented on AVRO-134:
-----------------------------------
This looks good to me. I would prefer we call this the "null" codec rather
than the "raw" codec. I also think that if no codec is specified in a file
then we should assume the null codec rather than throw an exception.
Note that this is similar to HTTP's content-codings
(http://www.w3.org/Protocols/rfc2616/rfc2616-sec3.html#sec3.5). HTTP names the
default codec "identity", which I'd also be okay with, though I prefer "null".
It's not an error in HTTP to leave the codec unspecified. They also use
"deflate" to refer to zlib, which has created confusion according to
http://www.zlib.net/zlib_faq.html#faq39, so I think "zlib" is a better name for
us to use, when we get to that.
> checkstyle doesn't like constants-only interfaces.
We could change that by removing the "InterfaceIsType" line from
src/java/checkstyle.xml.
http://checkstyle.sourceforge.net/config_design.html#InterfaceIsType
However, if this were an interface, would you want DataFileReader/Writer to
implement it? I'd rather avoid that, as it would force the interface public,
and I do not want to clutter the public, documented API with this.
> Mismatch between the spec and implementation of metadata blocks in files
> ------------------------------------------------------------------------
>
> Key: AVRO-134
> URL: https://issues.apache.org/jira/browse/AVRO-134
> Project: Avro
> Issue Type: Bug
> Reporter: Thiruvalluvan M. G.
> Attachments: AVRO-134.patch
>
>
> The spec says there are three keys in metadata blocks - schema, count and
> _codec_. But the code in DataFileWriter adds schema, count and _sync_. The
> sync field is used by the DataFileReader. We need to do the following:
> - Add the key sync in the specification.
> - Either drop the key codec in the specification or add code to support
> codec in DataFileReader/DataFileWriter. If we decide to have codec, we need
> to also publish in the spec the list of supported codecs with their names to
> use in the metadata block.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
